linux-kernel - Re: [PATCH] usbatm_heavy_init: don't use CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200704140059.23475.baldrick@free.fr>
Date:	Sat, 14 Apr 2007 00:59:23 +0200
From:	Duncan Sands <baldrick@...e.fr>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbatm_heavy_init: don't use CLONE_SIGHAND

On Friday 13 April 2007 01:56:31 Oleg Nesterov wrote:
> usbatm_do_heavy_init() calls allow_signal() which plays with parent process's
> ->sighand.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Acked-by: Duncan Sands <baldrick@...e.fr>

> --- 2.6.21-rc5/drivers/usb/atm/usbatm.c~usbatm	2006-11-27 21:19:30.000000000 +0300
> +++ 2.6.21-rc5/drivers/usb/atm/usbatm.c	2007-04-13 03:34:56.000000000 +0400
> @@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
>  
>  static int usbatm_heavy_init(struct usbatm_data *instance)
>  {
> -	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
> +	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
>  
>  	if (ret < 0) {
>  		usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);
> 
> 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/