linux-kernel - Re: [RFC] [Patch 0/4] timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Apr 2007 15:07:27 +0200
From:	Thomas Gleixner <tglx@...esys.com>
To:	Martin Peschke <mp3@...ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-s390@...r.kernel.org, d.pensator@...il.com, mingo@...hat.com
Subject: Re: [RFC] [Patch 0/4] timer_stats slimmed down

Martin,

On Sat, 2007-04-14 at 12:09 +0200, Martin Peschke wrote:
> 2.6.21-rc* kernels come with a feature that adds timer statistics
> to /proc/timer_stats (CONFIG_TIMER_STATS). This patch set makes it use
> the proposed statistics infrastructure (-mm tree), and adds prequisite
> functions to the statistics code.
> 
> The result are noticeable lines of code savings.
> kernel/time/timer_stats.c which comes with several functions which can
> be made redundant by using corresponding functions of lib/statistic.c,
> that is:
> 
> - accounting
> - printing output in sequential files
> - user interface for switching accounting on/off, reset etc.
> - measuring the accounting time
> - per-cpu optimisations
> 
> Function that were missing in lib/statistics, and which are added by
> this patch set, are:
> 
> - allow arbitrary keys for statistics entries (e.g. structures)
> - allow client to label output of statistics entries (e.g. using keys)
> 
> A secondary effect of the patch set is that we won't add another entry
> to good old /proc. The statistics infrastructure uses debugfs.
> 
> This patch set is a prototype that works for me, but which might allow
> for optimisations. Suggestions are welcome.

I'm a bit short of time to take a closer look, but on the first glance
it looks good to me. I give it a whirl, when I'm back from travelling.

	tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/