linux-kernel - Re: [PATCH] ALPHA: support graphics on non-zero PCI domains (take 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070415123020.GA19688@uranus.ravnborg.org>
Date:	Sun, 15 Apr 2007 14:30:20 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Henderson <rth@...ddle.net>,
	Jay Estabrook <jay.estabrook@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALPHA: support graphics on non-zero PCI domains (take 2)

> 
> > > +#ifndef CONFIG_ALPHA_GENERIC
> > > +EXPORT_SYMBOL(tsunami_ioportmap);
> > > +EXPORT_SYMBOL(tsunami_ioremap);
> > > +#endif
> > 
> > It looks strange that the function is always defined but conditionally exported.
> > Also usual style is to place EXPORT right after closing brace of function -
> > (with no empty lines in-between).
> 
> In a generic kernel the IO functions are never addressed directly,
> only via machine vector, so there is no point in exporting them.
> What about something like EXPORT_SYMBOL_NONGENERIC() macro?
As I wrote it looked strange. Unconditionally exporting them should not harm
and then we are one pair of ifdef/endif shorter?

Nitty gritty detail so do what you think match best.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/