linux-kernel - Re: [patch] use C99 initialisers for PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46222051.9010104@garzik.org>
Date:	Sun, 15 Apr 2007 08:53:37 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Ulrich Eckhardt <doomster@...ut.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [patch] use C99 initialisers for PCI_VDEVICE()

Ulrich Eckhardt wrote:
> (Note: CC me please, I'm not subscribed.)
> 
> Not much to say about the patch (it's against 2.6.20.6), it just converts a 
> macro to generate C99-style initialisers.
> 
> --- include/linux/pci.h   (revision 17)
> +++ include/linux/pci.h   (working copy)
> @@ -407,9 +407,10 @@
>   * private data.
>   */
>  
> -#define PCI_VDEVICE(vendor, device)            \
> -       PCI_VENDOR_ID_##vendor, (device),       \
> -       PCI_ANY_ID, PCI_ANY_ID, 0, 0
> +#define PCI_VDEVICE(vend, dev)         \
> +       .vendor=PCI_VENDOR_ID_##vend, .device=(dev),    \
> +       .subvendor=PCI_ANY_ID, .subdevice=PCI_ANY_ID,   \
> +       .class=0, .class_mask=0

NAK.  C99 initializers were intentionally avoided.  Look at the usage of 
this macro.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/