linux-kernel - Re: [PATCH] hid: hid bus prototype 20070416

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.0.98.0704161504280.18903@jikos.suse.cz>
Date:	Mon, 16 Apr 2007 15:22:25 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Li Yu <raise.sail@...il.com>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	linux-usb-devel <linux-usb-devel@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>,
	杨红 <yanghong@...ss.com.cn>,
	洪志毅 <hongzhiyi@...ss.com.cn>
Subject: Re: [PATCH] hid: hid bus prototype 20070416

On Mon, 16 Apr 2007, Li Yu wrote:

> HID bus prototype 20070416

Hi Li,

thanks for taking care. Well, the patch is quite huge, do you think you 
could split it into separate independent parts (use quilt or something 
similar for patch management) which could be reviewed independently?

As the code changes are often quite non-trivial, layering is changed, 
lots of files are touched, etc. it would help a lot.

Notes from a quick skim through the patch:

- it seems that you accidentaly deleted the newly added quirk for
   mightymouse in the bluetooth hid code?
- what is the point behind HID_QUIRK_SKIP? Why doesn't HID_QUIRK_IGNORE
   suffice? And why is it defined in so strange way:

@@ -270,6 +271,7 @@ struct hid_item {
  #define HID_QUIRK_LOGITECH_DESCRIPTOR          0x00100000
  #define HID_QUIRK_DUPLICATE_USAGES             0x00200000
  #define HID_QUIRK_RESET_LEDS                   0x00400000
+#define HID_QUIRK_SKIP                         0x80000000

- there are bunches of some easy codingstyle issues (spaces around '=',
   etc)

But doing really thorough review is quite hard, as the patch contains lots 
of unrelated changes. I'll look at it a little bit more, but when you send 
a broken-out version with separate changes, that'd be great.

Thanks,

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/