linux-kernel - Re: [PATCH v2] hpet: Enable hidden HPET on NVidia motherboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.OSF.4.64.0704161624010.487506@kosh.hut.fi>
Date:	Mon, 16 Apr 2007 16:33:13 +0300 (EEST)
From:	Mikko Tiihonen <mikko.tiihonen@....fi>
To:	Krzysztof Halasa <khc@...waw.pl>
cc:	clemens@...isch.de, bob.picco@...com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] hpet: Enable hidden HPET on NVidia motherboards


On Mon, 16 Apr 2007, Krzysztof Halasa wrote:

> Mikko Tiihonen <mikko.tiihonen@....fi> writes:
>
>> Enables HPET for NVidia motherboards with broken BIOS. The patch reads
>> the HPET address from the pci config space. The patch should also work
>> if ACPI is disabled.
>>
>> The HPET search is done in early-quirks because even
>> DECLARE_PCI_FIXUP_EARLY was too late. If the new quirk causes problems
>> it can be disabled with the nohpet boot option.
>>
>> The patch assumes that the BIOS has done the basic setup of HPET, but
>> has not published the result in ACPI tables. This is at least true for
>> some Asus and Gigabyte motherboards.
>
> I think the code should only be enabled by its CONFIG_*.

Currently the all the code is protected by CONFIG_HPET.
Are you proposing to use for example CONFIG_HPET_NVIDIA instead?

I think that the code should be safe even without it's own config option.
It won't override values from ACPI tables and can still be disabled with
nohpet boot option. Also all the code and data are __init.

-Mikko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/