linux-kernel - Re: [PATCH] Set a separate lockdep class for neighbour table's proxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070417.124610.63508619.davem@davemloft.net>
Date:	Tue, 17 Apr 2007 12:46:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...ru
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH] Set a separate lockdep class for neighbour table's
 proxy_queue

From: Pavel Emelianov <xemul@...ru>
Date: Mon, 16 Apr 2007 16:08:25 +0400

> Otherwise the following calltrace will lead to a wrong
> lockdep warning:
> 
>   neigh_proxy_process()
>     `- lock(neigh_table->proxy_queue.lock);
>   arp_redo /* via tbl->proxy_redo */
>   arp_process
>   neigh_event_ns
>   neigh_update
>   skb_queue_purge
>     `- lock(neighbor->arp_queue.lock);
> 
> This is not a deadlock actually, as neighbor table's proxy_queue
> and the neighbor's arp_queue are different queues.
> 
> Lockdep thinks there is a deadlock as both queues are initialized
> with skb_queue_head_init() and thus have a common class.

Patch applied, thank you.

Please provide a proper "Signed-off-by: " line in future patch
submissions or else I will ignore your patches entirely.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/