[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <E1HeV12-0002IS-00@gondolin.me.apana.org.au>
Date: Thu, 19 Apr 2007 21:41:32 +1000
From: Herbert Xu <herbert@...dor.apana.org.au>
To: herbert@...dor.apana.org.au (Herbert Xu)
Cc: paulus@...ba.org, davem@...emloft.net, kaber@...sh.net,
poemann@...il.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: kernel BUG at net/core/skbuff.c in linux-2.6.21-rc6
Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> Paul Mackerras <paulus@...ba.org> wrote:
>>
>> So this doesn't change process_input_packet(), which treats the case
>> where the first byte is 0xff (PPP_ALLSTATIONS) but the second byte is
>> 0x03 (PPP_UI) as indicating a packet with a PPP protocol number of
>> 0xff. Arguably that's wrong since PPP protocol 0xff is reserved, and
>> the RFC does envision the possibility of receiving frames where the
>> control field has values other than 0x03.
>
> Your fix is probably needed too. However, I think the issue that Patrick
> was trying to fix is the case where p[0] != PPP_ALLSTATIONS and therefore
> we'd still have a problem there.
Nevermind, I mixed up != with == so your patch is all we need.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists