[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070419163740.9035654d.akpm@linux-foundation.org>
Date: Thu, 19 Apr 2007 16:37:40 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: <containers@...ts.osdl.org>, Oleg Nesterov <oleg@...sign.ru>,
Christoph Hellwig <hch@...radead.org>,
<linux-kernel@...r.kernel.org>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] macintosh/therm_windtunnel.c: Convert to kthread API.
On Thu, 19 Apr 2007 01:58:48 -0600
"Eric W. Biederman" <ebiederm@...ssion.com> wrote:
> Start the g4fand using kthread_run not a combination
> of kernel_thread and deamonize. This makes the code
> a little simpler and more maintainable.
I had a bit of trouble reviewing this one because I was laughing so hard at
the attempted coding-style in that driver. Oh well.
I continue creeping into Christoph's camp - there's quite a bit of
open-coded gunk which would go away if we were to teach this driver about
kthread_should_stop() and kthread_stop(), and the conversion looks awfully
easy to do. It's a shame to stop here.
Oh well, I guess at least this is some forward progress.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists