| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070420110119.GS32602149@melbourne.sgi.com> Date: Fri, 20 Apr 2007 21:01:19 +1000 From: David Chinner <dgc@....com> To: Jarek Poplawski <jarkao2@...pl> Cc: David Chinner <dgc@....com>, linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu> Subject: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work On Fri, Apr 20, 2007 at 12:21:57PM +0200, Jarek Poplawski wrote: > On Fri, Apr 20, 2007 at 06:53:54PM +1000, David Chinner wrote: > ... > > Yes, after spending another two hours working out why my fix was > > then hanging in cancel_rearming_delayed_work() I was a little bit > > annoyed at the now obviously misleading comment. Five minutes later > > I agree with your feelings, but strictly speaking it's not "obviously > misleading": > > " * cancel_rearming_delayed_work - reliably kill off a delayed > keventd work whose handler rearms the delayed work." " This is not reliable if the handler rearms itself conditionally and it is restarted by external means." > And all your rearmed works were, probably, reliably killed! Yeah, it's the ones that weren't that we the problem ;) > > I'd fixed the bug properly. A better comment would have saved me two > > hours of wasted time..... > > It seems to be an Achilles' heel of linux... Too true.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists