linux-kernel - Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070420183118.GA695@elte.hu>
Date:	Fri, 20 Apr 2007 20:31:18 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	ego@...ibm.com, "Rafael J. Wysocki" <rjw@...k.pl>,
	Oleg Nesterov <oleg@...sign.ru>, linux-kernel@...r.kernel.org,
	vatsa@...ibm.com, paulmck@...ibm.com, pavel@....cz
Subject: Re: [RFC PATCH(experimental) 2/2] Fix freezer-kthread_stop race


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> > > I mean, we already have four of them (PF_NOFREEZE, PF_FROZEN, 
> > > PF_FREEZER_SKIP, TIF_FREEZE), and you will need to introduce two 
> > > more for the freezer-based CPU hotplug, so if yet another one is 
> > > needed, that will make up almost a separate u8 field ...
> > 
> > I am perfectly ok with it. But I am not sure if everybody would 
> > agree to have another field in the task struct, though in this case 
> > it does make sense :-)
> 
> OK by me.  You might want to consider making that fields's locking 
> protocol be set_bit(), clear_bit(), etc rather than task_lock().

is OK to me too, the extra field isnt a problem.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/