linux-kernel - Re: [PATCH] use spinlock instead of binary mutex in idt77252 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <45C4C5F0-4F09-416D-A237-82FC28DF1883@mac.com>
Date:	Sun, 22 Apr 2007 19:50:36 -0400
From:	Kyle Moffett <mrmacman_g4@....com>
To:	Matthias Kaehlcke <matthias.kaehlcke@...il.com>
Cc:	chas@....nrl.navy.mil, ecd@...com.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in idt77252 driver

On Apr 22, 2007, at 17:39:59, Matthias Kaehlcke wrote:
> use spinlock instead of binary mutex in idt77252 driver

I think you really meant: "Use mutex instead of binary semaphore in  
idt77252 driver", since this is a binary semaphore (not a mutex,  
which are always binary):
> -	struct semaphore	mutex;

and this is a mutex, not a spinlock:
> +	struct mutex		mutex;

Everything else looks good though

Cheers,
Kyle Moffett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/