linux-kernel - Re: [PATCH] sl82c105: Switch to ref counting API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <462CBCD2.3080302@ru.mvista.com>
Date:	Mon, 23 Apr 2007 18:04:02 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH] sl82c105: Switch to ref counting API

Hello.

Alan Cox wrote:

> Not sure how this one got missed in the great purge some time ago but it
> did. 

> Signed-off-by: Alan Cox <alan@...hat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c linux-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c
> --- linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c	2007-04-12 14:15:04.000000000 +0100
> +++ linux-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c	2007-04-23 11:58:55.016516864 +0100
> @@ -349,7 +349,7 @@
>  	/*
>  	 * The bridge should be part of the same device, but function 0.
>  	 */
> -	bridge = pci_find_slot(dev->bus->number,
> +	bridge = pci_get_bus_and_slot(dev->bus->number,
>  			       PCI_DEVFN(PCI_SLOT(dev->devfn), 0));

   Isn't it better to use pci_get_slot()?

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/