linux-kernel - Re: [PATCH -mm] 64bit-futex - provide new commands instead of new syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a36005b50704230830p2a4d55e2i61627b00788cd4d2@mail.gmail.com>
Date:	Mon, 23 Apr 2007 08:30:57 -0700
From:	"Ulrich Drepper" <drepper@...il.com>
To:	"Pierre Peiffer" <pierre.peiffer@...l.net>
Cc:	"Jakub Jelinek" <jakub@...hat.com>, akpm@...ux-foundation.org,
	mingo@...e.hu, drepper@...hat.com, linux-kernel@...r.kernel.org,
	jean-pierre.dion@...l.net
Subject: Re: [PATCH -mm] 64bit-futex - provide new commands instead of new syscall

On 4/23/07, Pierre Peiffer <pierre.peiffer@...l.net> wrote:
> Following this mail sent few weeks ago, here is a patch which should meet your
> requirements. [...]

It looks mostly good.  I wouldn't use the high bit to differentiate
the 64-bit operations, though.  Since we do not allow to apply it to
all operations the only effect will be that the compiler has a harder
time generating the code for the switch statement.  If you use
continuous values a simple jump table can be used and no conditionals.
 Smaller and faster.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/