linux-kernel - Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070423054213.GQ5013@traven>
Date:	Mon, 23 Apr 2007 07:42:14 +0200
From:	Matthias Kaehlcke <matthias.kaehlcke@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	emoenke@...g.de, minyard@...rch.cirr.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver

El Mon, Apr 23, 2007 at 01:25:58AM +0200 Andi Kleen ha dit:

> Matthias Kaehlcke <matthias.kaehlcke@...il.com> writes:
> 
> > -static DECLARE_MUTEX(sony_sem);		/* Semaphore for drive hardware access */
> > +static DEFINE_MUTEX(sony_mtx);		/* Mutex for drive hardware access */
> 
> That's not a spinlock.  Also normally some rationale is added to the
> description for a change?

sorry i messed up the description of the change, i meant mutex instead
of spinlock (in the last days i reported some spinlock related bugs
...). 

the rationale is that according to http://lwn.net/Articles/167034/
binary semaphores that aren't given in interrupt context or
locked and unlocked by different processes should be replaced by
mutexes

thanks for your comments

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

              La posibilidad de realizar un suenyo es lo
                 que hace que la vida sea interesante
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/