lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Apr 2007 16:04:16 +0200 From: Gerd Hoffmann <kraxel@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> CC: linux-kernel@...r.kernel.org, Paul Mundt <lethal@...ux-sh.org>, Ralf Baechle <ralf@...ux-mips.org>, Andi Kleen <ak@...e.de>, Alan Cox <alan@...rguk.ukuu.org.uk>, Richard Henderson <rth@...ddle.net>, Ivan Kokshaysky <ink@...assic.park.msu.ru>, Paul Mackerras <paulus@...ba.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Jeremy Fitzhardinge <jeremy@...p.org> Subject: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console. > I get this, across netconsole: > > [17179569.184000] console handover: boot [earlyvga_f._0] -> real [tty0] > > wanna take a look at why there's cruft in bootconsole->name please? -EFULL ;) "earlyvga" is 8 chars. struct console->name is char[8]. No space left for the trailing ´\0´, the cruft comes from the next field (write function pointer). Obviously nobody ever printed the early console names before. Hmm. We can make the names shorter. We can make the name field longer (probably 16, it ends up taking that much anyway due to aligments at least on 64bit). This looks best to me. We could also use printk("%.8s",name) to make printk stop after 8 chars, but I somehow don't like hardcoding the length like this ... cheers, Gerd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists