linux-kernel - Re: [PATCH] use mutex instead of semaphore in RocketPort driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704241953.04336.oneukum@suse.de>
Date:	Tue, 24 Apr 2007 19:53:04 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Matthias Kaehlcke <matthias.kaehlcke@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use mutex instead of semaphore in RocketPort driver

Am Dienstag, 24. April 2007 19:49 schrieb Matthias Kaehlcke:
> @@ -1706,7 +1706,7 @@ static int rp_write(struct tty_struct *tty,
>         if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
>                 return 0;
>  
> -       down_interruptible(&info->write_sem);
> +       mutex_lock_interruptible(&info->write_mtx);

This is a bug. It is also present in the current code, but nevertheless
it is a bug. If you use an interruptible lock, you must be ready to deal
with interrupts, which are ignored by this code.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/