linux-kernel - Re: [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704242050.49253.ak@suse.de>
Date:	Tue, 24 Apr 2007 20:50:48 +0200
From:	Andi Kleen <ak@...e.de>
To:	Ashok Raj <ashok.raj@...el.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org, gregkh@...e.de,
	muli@...ibm.com, asit.k.mallick@...el.com,
	suresh.b.siddha@...el.com, anil.s.keshavamurthy@...el.com,
	arjan@...ux.intel.com, shaohua.li@...el.com
Subject: Re: [Intel IOMMU][patch 1/8] ACPI support for Intel Virtualization Technology for Directed I/O


> +config DMAR
> +	bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
> +	depends on PCI_MSI && ACPI && EXPERIMENTAL
> +	help
> +	  Support DMA Remapping Devices. The devices are reported via
> +	  ACPI tables and includes pci device scope under each DMA
> +	  remapping device.

The description needs to explain what a dma remapping device is.


And some high level comment here what this file does.

> +
> +LIST_HEAD(dmar_drhd_units);
> +LIST_HEAD(dmar_rmrr_units);

Comment describing what lock protects those lists?
In fact there seems to be no locking. What about hotplug?

>
> +
> +	dmar = (struct acpi_table_dmar *)table;
> +	if (!dmar) {
> +		printk (KERN_WARNING PREFIX "Unable to map DMAR\n");
> +		return -ENODEV;
> +	}

Shouldn't that be wherever the table is mapped. Or is it not needed?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/