linux-kernel - Re: [PATCH 23/25] xen: Lockdep fixes for xen-netfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HgBbr-0007Ob-00@gondolin.me.apana.org.au>
Date:	Tue, 24 Apr 2007 13:22:31 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jeremy@...p.org (Jeremy Fitzhardinge)
Cc:	ak@...e.de, chrisw@...s-sol.org, virtualization@...ts.osdl.org,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 23/25] xen: Lockdep fixes for xen-netfront

Jeremy Fitzhardinge <jeremy@...p.org> wrote:
>
> @@ -1212,10 +1212,10 @@ static int netif_poll(struct net_device 
>        int pages_flipped = 0;
>        int err;
> 
> -       spin_lock(&np->rx_lock);
> +       spin_lock_bh(&np->rx_lock);
> 
>        if (unlikely(!netfront_carrier_ok(np))) {
> -               spin_unlock(&np->rx_lock);
> +               spin_unlock_bh(&np->rx_lock);

You don't need to disable BH in netif_poll since it's always called
with BH disabled.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/