linux-kernel - Re: [PATCH 2/10] safe_apic_wait_icr_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704251511.59495.ak@suse.de>
Date:	Wed, 25 Apr 2007 15:11:59 +0200
From:	Andi Kleen <ak@...e.de>
To:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>, horms@...ge.net.au,
	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
	vgoyal@...ibm.com, mbligh@...gle.com,
	Keith Owens <kaos@....com.au>, akpm@...ux-foundation.org
Subject: Re: [PATCH 2/10] safe_apic_wait_icr_idle - x86_64

On Wednesday 25 April 2007 14:55:12 Fernando Luis Vázquez Cao wrote:
> On Wed, 2007-04-25 at 14:26 +0200, Andi Kleen wrote:
> > >  static __inline__ void apic_wait_icr_idle(void)
> > >  {
> > > -	while (apic_read( APIC_ICR ) & APIC_ICR_BUSY)
> > > +	while (apic_read(APIC_ICR) & APIC_ICR_BUSY)
> > >  		cpu_relax();
> > >  }
> > >  
> > > +static __inline__ unsigned int safe_apic_wait_icr_idle(void)
> > 
> > This should be probably not inline -- too large
> Hello Andi,
> 
> Thank you for reviewing the patches. Do you want me to resend the whole
> patch or should I cook a new one that un-inlines the function instead?

I already did that.

Also will apply Keith's suggestion.

-Andi



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/