linux-kernel - Re: W1 printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2007 16:45:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	johnpol@....mipt.ru, lkml <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: W1 printk format warning

On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@...cle.com> wrote:

> in 2.6.21-rc7-mm1.  Are you aware of this?
> 
> drivers/w1/w1.c:460: warning: too few arguments for format
> 
> 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> 		&sl->dev.bus_id[0]);
> 

Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
printk arg-checking to dev_dbg() and a bunch of bugs got exposed.  I fixed
a few of them.

Incidentally, there are at least four different drivers which privately do
things like:

#if !defined(DEBUG)
#undef dev_dbg
static inline int __attribute__ ((format (printf, 2, 3))) dev_dbg(
	const struct device *_dev, const char *fmt, ...) {return 0;}
#endif

which can all be removed with Dan's (good) patch in place.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/