linux-kernel - RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <46306C51.76E4.0078.0@novell.com>
Date:	Thu, 26 Apr 2007 08:09:37 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Haruo Tomita" <haruo.tomita@...hiba.co.jp>
Cc:	<prarit@...hat.com>, "lkml" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2]  Fixed typo Intel RNG driver for2.6.21-rc7-mm1

>>> "Tomita, Haruo" <haruo.tomita@...hiba.co.jp> 26.04.07 08:56 >>>
>> But why do you remove the printk()?
>
>I think that FWH connected to LPC of ICHx are not only Intel products.
>For example, sst... etc.
>Does rng address differ in except Intel products? 

I am not aware of non-Intel FWHs supporting the same RNG interface.

>I think that this driver is targeting Intel FWH.
>Therefore, printk() was removed.

If you're worried about people thinking their box being reported to have no
FWH when it does, then just make the message say so (i.e. add 82802 or
alike).

># Do you think that a "FWH not detected" message is noisy?

No, I think it helps understanding why there's no RNG device in the system.

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/