linux-kernel - Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070426141306.59a954d8@the-village.bc.nu>
Date:	Thu, 26 Apr 2007 14:13:06 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	davej@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs

On Wed, 25 Apr 2007 19:21:58 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
> >  {
> >  	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
> >  
> > +	pci_dev_put(bridge->dev);
> >  	agp_remove_bridge(bridge);
> >  	agp_put_bridge(bridge);
> > +	pci_dev_put(serverworks_private.svrwrks_dev)
> > +	serverworks_private.svrwrks_dev = NULL;
> 
> err, guys?

I merely fixed the code to refcount, the actual code itself is complete
bollocks and does exactly what that implies. It also explodes if you ever
use the hotplug testing code to simulate a plug or replug and goes
completely bonkers if you put two of them in a qemu simulator 8)

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/