[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4630109F.6090002@oracle.com>
Date: Wed, 25 Apr 2007 19:38:23 -0700
From: Randy Dunlap <randy.dunlap@...cle.com>
To: Dave Jones <davej@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Randy Dunlap <randy.dunlap@...cle.com>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
mb@...sch.de, linville@...driver.com, arnd@...db.de,
maxextreme@...il.com, gregkh@...e.de
Subject: Re: [PATCH 0/9] Kconfig: cleanup s390 v2.
Dave Jones wrote:
> On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote:
>
> > It would be neat if someone could create and maintain a new
> > scripts/spot-common-mistakes. Feed it a unified diff and it would complain
> > about newly-added code (and only newly-added code) which has busted
> > whitespace, adds new semaphores, adds new kernel_thread calls, etc, etc.
>
> years and years ago, when the dinosaurs roamed the land, I hacked up..
> http://janitor.kernelnewbies.org/scripts/ and then left it by the wayside.
> Some of the checks it did are actually bogus, but I'm happy to pick that
> up again if there's interest in it being a useful tool.
>
> In fact, I should probably munge it together with a similar thing
> I wrote at http://www.codemonkey.org.uk/projects/findbugs/
> (Warning: scary regexps)
>
> > It would need to be fairly simple and easily-extensible, as I can
> > imagine quite a few things getting added to it.
> >
> > (Imagines a procmail rule which just bounces the email if
> > spot-common-mistakes failed)
>
> or a git checkin rule that refuses to commit if it fails ;-)
Yep, I was going to mention your scripts but you beat me to it.
I'll be glad to help maintain such animals if wanted.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists