linux-kernel - Re: Linux-2.6.21 hangs during post boot initialization phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46319297.905@bigpond.net.au>
Date:	Fri, 27 Apr 2007 16:05:11 +1000
From:	Peter Williams <pwil3058@...pond.net.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Neil Horman <nhorman@...driver.com>
Subject: Re: Linux-2.6.21 hangs during post boot initialization phase

Linus Torvalds wrote:
> 
> On Fri, 27 Apr 2007, Peter Williams wrote:
>> The 2.6.21 kernel is hanging during the post boot phase where various daemons
>> are being started (not always the same daemon unfortunately).
>>
>> This problem was not present in 2.6.21-rc7 and there is no oops or other
>> unusual output in the system log at the time the hang occurs.
> 
> Can you use "git bisect" to narrow it down a bit more? It's only 125 
> commits, so bisecting even just three or four kernels will narrow it down 
> to a handful.

As the changes became, smaller the builds became quicker :-) and after 7 
iterations we have:


author	Neil Horman <nhorman@...driver.com>
	Fri, 20 Apr 2007 13:54:58 +0000 (09:54 -0400)
committer	Jeff Garzik <jeff@...zik.org>
	Tue, 24 Apr 2007 16:43:07 +0000 (12:43 -0400)
commit	b748d9e3b80dc7e6ce6bf7399f57964b99a4104c
tree	887909e1f735bb444ef0e3e370f34401fa6eee02	tree | snapshot
parent	d91c088b39e3c66d309938de858775bb90fd1ead	commit | diff
sis900: Allocate rx replacement buffer before rx operation

The sis900 driver appears to have a bug in which the receive routine
passes the skbuff holding the received frame to the network stack before
refilling the buffer in the rx ring.  If a new skbuff cannot be 
allocated, the
driver simply leaves a hole in the rx ring, which causes the driver to stop
receiving frames and become non-recoverable without an rmmod/insmod 
according to
reporters.  This patch reverses that order, attempting to allocate a 
replacement
buffer first, and receiving the new frame only if one can be allocated. 
  If no
skbuff can be allocated, the current skbuf in the rx ring is recycled, 
dropping
the current frame, but keeping the NIC operational.

Signed-off-by: Neil Horman <nhorman@...driver.com>
Signed-off-by: Jeff Garzik <jeff@...zik.org>

Peter
-- 
Peter Williams                                   pwil3058@...pond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
  -- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/