linux-kernel - Re: [PATCH] serial 8250: move push calls out of lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2007 08:09:23 -0500
From:	Corey Minyard <minyard@....org>
To:	Corey Minyard <minyard@....org>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-serial@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] serial 8250: move push calls out of lock

Corey Minyard wrote:
> Russell King wrote:    
>>
>> Use of an uninitialised variable.  The reason we use check_modem_status
>> to return the current status here is because reading the MSR _clears_
>> interrupts.  So, repeatedly calling get_mctrl via an ioctl is a great
>> way to introduce a hardware race condition if you just read the MSR and
>> never act on it.
>>   
> "status" is used as a return variable; it is set by the call.  I modified
> check_modem_status() to return if it detected a change and set the
> status if it was passed in.
Ok, I see what I missed.  Never mind.

-corey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/