linux-kernel - [PATCH] Move LOG_BUF_SHIFT to a more sensible place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704272053.32502.s0348365@sms.ed.ac.uk>
Date:	Fri, 27 Apr 2007 20:53:32 +0100
From:	Alistair John Strachan <s0348365@....ed.ac.uk>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	"Sunil Naidu" <akula2.shark@...il.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Frederik Deweerdt" <deweerdt@...e.fr>,
	"Andrew Morton" <akpm@...ux-foundation.org>, trivial@...nel.org
Subject: [PATCH] Move LOG_BUF_SHIFT to a more sensible place

Several people have observed that perhaps LOG_BUF_SHIFT should be in a more 
obvious place than under DEBUG_KERNEL. Under some circumstances (such as the 
PARISC architecture), DEBUG_KERNEL can increase kernel size, which is an 
undesirable trade off for something as trivial as increasing the kernel log 
buffer size.

Instead, move LOG_BUF_SHIFT into "General Setup", so that people are more 
likely to be able to change it such a circumstance that the default buffer 
size is insufficient.

Signed-off-by: Alistair John Strachan <s0348365@....ed.ac.uk>
---

diff --git a/init/Kconfig b/init/Kconfig
index b170aa1..cc9eb35 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -262,6 +262,23 @@ config IKCONFIG_PROC
 	  This option enables access to the kernel configuration file
 	  through /proc/config.gz.
 
+config LOG_BUF_SHIFT
+	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)"
+	range 12 21
+	default 17 if S390 || LOCKDEP
+	default 16 if X86_NUMAQ || IA64
+	default 15 if SMP
+	default 14
+	help
+	  Select kernel log buffer size as a power of 2.
+	  Defaults and Examples:
+	  	     17 => 128 KB for S/390
+		     16 => 64 KB for x86 NUMAQ or IA-64
+	             15 => 32 KB for SMP
+	             14 => 16 KB for uniprocessor
+		     13 =>  8 KB
+		     12 =>  4 KB
+
 config CPUSETS
 	bool "Cpuset support"
 	depends on SMP
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 3f3e740..de82401 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -86,23 +86,6 @@ config DEBUG_SHIRQ
 	  Drivers ought to be able to handle interrupts coming in at those
 	  points; some don't and need to be caught.
 
-config LOG_BUF_SHIFT
-	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)" if DEBUG_KERNEL
-	range 12 21
-	default 17 if S390 || LOCKDEP
-	default 16 if X86_NUMAQ || IA64
-	default 15 if SMP
-	default 14
-	help
-	  Select kernel log buffer size as a power of 2.
-	  Defaults and Examples:
-	  	     17 => 128 KB for S/390
-		     16 => 64 KB for x86 NUMAQ or IA-64
-	             15 => 32 KB for SMP
-	             14 => 16 KB for uniprocessor
-		     13 =>  8 KB
-		     12 =>  4 KB
-
 config DETECT_SOFTLOCKUP
 	bool "Detect Soft Lockups"
 	depends on DEBUG_KERNEL && !S390

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/