linux-kernel - Re: [PATCH] h8300 generic irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070428084225.GA22480@infradead.org>
Date:	Sat, 28 Apr 2007 09:42:25 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] h8300 generic irq

On Fri, Apr 27, 2007 at 07:09:35PM -0700, Andrew Morton wrote:
> > +/*
> > + * h8300 interrupt controler implementation
> > + */
> > +struct irq_chip h8300irq_chip = {
> > +	.name		= "H8300-INTC",
> > +	.startup	= h8300_startup_irq,
> > +	.shutdown	= h8300_shutdown_irq,
> > +	.enable		= h8300_enable_irq,
> > +	.disable	= h8300_disable_irq,
> > +	.ack		= NULL,
> > +	.end		= h8300_end_irq,
> > +};
> 
> I think this could have static scope.

Pluse there's not need to set .ack to NULL explicitly.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/