linux-kernel - Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463364CF.20801@garzik.org>
Date:	Sat, 28 Apr 2007 11:14:23 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Rolf Eike Beer <eike-kernel@...tec.de>
CC:	linux-kernel@...r.kernel.org, Tejun Heo <htejun@...il.com>,
	Greg KH <greg@...ah.com>
Subject: Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt

Rolf Eike Beer wrote:
> Above and below we talk about my_midlayer_create_something, I assume that is
> also meant here.
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@...tec.de>
> 
> ---
> commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
> tree cd948e03b4add89be6e648d31b7778c64a51e8d2
> parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
> author Rolf Eike Beer <eike-kernel@...tec.de> Thu, 26 Apr 2007 09:23:39 +0200
> committer Rolf Eike Beer <eike-kernel@...tec.de> Thu, 26 Apr 2007 09:23:39 +0200
> 
>  Documentation/driver-model/devres.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 5163b85..6c8d8f2 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -182,7 +182,7 @@ For example, you can do something like the following.
>  
>  	...
>  
> -	devres_close_group(dev, my_midlayer_something);
> +	devres_close_group(dev, my_midlayer_create_something);
>  	return 0;

hmmm.

Now that devres is in the kernel, I don't think I am the best person to 
merge these sort of patches.  Certainly I can, and I know the code from 
my original review and subsequent usage, but I think the patch is more 
appropriate for Greg, going through normal maintainership channels.

IOW, I think devres is too generic to be queued via libata-dev.git.

Tejun, comments?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/