linux-kernel - Re: [PATCHSET] sysfs: sysfs rework, take #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4633710A.7080508@gmail.com>
Date:	Sun, 29 Apr 2007 01:06:34 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	gregkh@...e.de, dmitry.torokhov@...il.com,
	cornelia.huck@...ibm.com, oneukum@...e.de, rpurdie@...ys.net,
	maneesh@...ibm.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHSET] sysfs: sysfs rework, take #2

Alan Stern wrote:
> On Sat, 28 Apr 2007, Tejun Heo wrote:
> 
>> Subject: [PATCHSET] sysfs: sysfs rework, take #2
>>
>> Hello, all.
>>
>> This is respin of syswork rework patchset in gregkh patch series.
>> Changes are...
> 
> ...
> 
>> All the known regrssions are fixed.  I think I've got all the
>> attr->owner but haven't verified with cross compiling yet, just
>> allyesconfig on x86-64 and i386.  I'll try to setup some cross compile
>> environments tomorrow and follow up if I can find more fallouts.
> 
> What have you done about the problem of device nodes getting unregistered
> while the corresponding sysfs directory is non-empty, say with child
> device directories still present?

That was a problem because the previous update of sysfs_drop_dentry()
depended on walking from the root of /sys to the associated dentry to
drop it - which is quite nice because all dentry management can be
isolated.  I tried fixing it by 1. deferring drop of dentry till all its
children are gone (last child kills the deferred parent) 2. recursively
dropping all children when the parent is deleted (later drop of the
child becomes noop) but they both can't work with shadow directories, so
I gave up on the approach and just made synchronization around
sd->s_dentry correct.  So, it's not an issue anymore.  Verified to work.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/