linux-kernel - [PATCH -rt] yet another irq storm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1177729964.19619.3.camel@localhost.localdomain>
Date:	Fri, 27 Apr 2007 23:12:44 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH -rt] yet another irq storm

Must be global warming, I'm getting a lot more irq storms than usual.

Now that I switched over to x86_64, I booted up and got another irq
storm. So I added my previous patch and it didn't fix it.  Looking
further, I found that the mask and unmask is done directly in the
x86_64/io_apic.c file.

This patch does basically the same thing as my previous patch, but to
the x86_64/io_apic.c file.

Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Index: linux-2.6.21-rt1/arch/x86_64/kernel/io_apic.c
===================================================================
--- linux-2.6.21-rt1.orig/arch/x86_64/kernel/io_apic.c
+++ linux-2.6.21-rt1/arch/x86_64/kernel/io_apic.c
@@ -1437,7 +1437,8 @@ static void ack_apic_level(unsigned int 
 	irq_complete_move(irq);
 #if defined(CONFIG_GENERIC_PENDING_IRQ) || defined(CONFIG_IRQBALANCE)
 	/* If we are moving the irq we need to mask it */
-	if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING)) {
+	if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING) &&
+	    !(irq_desc[irq].status & IRQ_INPROGRESS)) {
 		do_unmask_irq = 1;
 		mask_IO_APIC_irq(irq);
 	}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/