linux-kernel - Re: ACPI build problem (2.6.21 CONFIG_X86_64_ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704280159.46337.lenb@kernel.org>
Date:	Sat, 28 Apr 2007 01:59:46 -0400
From:	Len Brown <lenb@...nel.org>
To:	Steven Whitehouse <swhiteho@...hat.com>, Andi Kleen <ak@...e.de>,
	Shai Fultheim <shai@...lex86.org>,
	Ravikiran Thirumalai <kiran@...lex86.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: ACPI build problem (2.6.21 CONFIG_X86_64_ACPI_NUMA)

On Thursday 26 April 2007 09:26, you wrote:
> Hi,
> 
> With the attached kernel config I get the following build errors. They
> go away if I turn power management support on:
> 
> drivers/built-in.o: In function `acpi_bus_generate_event':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:294: undefined
> reference to `event_is_open'
> drivers/built-in.o: In function `acpi_bus_get_power':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:160: undefined
> reference to `acpi_power_get_inferred_state'
> drivers/built-in.o: In function `acpi_bus_set_power':
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:230: undefined
> reference to `acpi_power_transition'
> /home/steve/gfs2-2.6-fixes.git/drivers/acpi/bus.c:252: undefined
> reference to `acpi_power_transition'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This is with my gfs2 tree which is basically 2.6.21 plus a few patches
> which only affect gfs2/dlm, so its upstream to all intents and purposes.

CONFIG_ACPI depends on CONFIG_PM, yet this build fails because you have
CONFIG_ACPI=y and CONFIG_PM=n

Unfortunately kconfig doesn't trace dependencies when "select" is used,
making select sort of evil.  Ie. select can't target anything which
itself has dependencies.

In 2.6.15, b0bd35e622ffbda2c01dc67a0381c6a18817a29a added the select below,
and subsequently ACPI became dependent on PM, which broke your build.
Technically, this could have broken your build in other ways too
since ACPI already had other dependencies.

+# Dummy CONFIG option to select ACPI_NUMA from drivers/acpi/Kconfig.
+
+config X86_64_ACPI_NUMA
+       bool "ACPI NUMA detection"
+       depends on NUMA
+       select ACPI 
+       select ACPI_NUMA
+       default y
+       help
+	 Enable ACPI SRAT based node topology detection.

If you de-select CONFIG_X86_64_ACPI_NUMA then the select goes away
and kconfig should work properly.

It isn't immediately clear to me how the NUMA Kconfig patch is a step
forward, but perhaps the authors can comment.

-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/