linux-kernel - Re: [PATCH] crypto: Remove pointless padlock module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4633FBFF.7050202@oracle.com>
Date:	Sat, 28 Apr 2007 18:59:27 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Simon Arlott <simon@...e.lp0.eu>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	herbert@...dor.apana.org.au, michal@...ix.cz
Subject: Re: [PATCH] crypto: Remove pointless padlock module

Simon Arlott wrote:
> When this is compiled in it is run too early to do anything useful:
> [    6.052000] padlock: No VIA PadLock drivers have been loaded.
> [    6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
> [    6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.
> 
> When it's a module it isn't doing anything special, the same 
> functionality can be provided in userspace by "probeall padlock 
> padlock-aes padlock-sha" in modules.conf if it is required.
> 
> Signed-off-by: Simon Arlott <simon@...e.lp0.eu>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Michal Ludvig <michal@...ix.cz>
> ---
> drivers/crypto/Kconfig   |   16 ++----------
> drivers/crypto/Makefile  |    1 -
> drivers/crypto/padlock.c |   58 
> ----------------------------------------------
> 3 files changed, 3 insertions(+), 72 deletions(-)
> delete mode 100644 drivers/crypto/padlock.c
> 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index ff8c4be..f85cecc 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -1,10 +1,10 @@
> menu "Hardware crypto devices"
> 
> config CRYPTO_DEV_PADLOCK
> -    tristate "Support for VIA PadLock ACE"
> -    depends on X86_32
> +    bool "Support for VIA PadLock ACE"
> +    depends on CRYPTO && X86_32

All of drivers/crypto/Kconfig already depends on CRYPTO, so just
	depends on X86_32
should be enough.

> +    default y
>     select CRYPTO_ALGAPI
> -    default m
>     help
>       Some VIA processors come with an integrated crypto engine
>       (so called VIA PadLock ACE, Advanced Cryptography Engine)


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/