lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 29 Apr 2007 17:59:25 -0700 From: Randy Dunlap <randy.dunlap@...cle.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Dave Jones <davej@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: checkpatch, a patch checking script. On Fri, 27 Apr 2007 22:18:03 -0700 Andrew Morton wrote: > On Fri, 27 Apr 2007 23:08:05 -0400 Dave Jones <davej@...hat.com> wrote: > > > You can find the script at http://www.codemonkey.org.uk/projects/checkpatch/ > > hm. > ... > box:/usr/src/25> ~/checkpatch.pl patches/git-powerpc.patch > Checking patches/git-powerpc.patch: signoffs = 427 > kmalloc return shouldn't be cast. > 10969:+ char *out = (char*)kmalloc(count + 1, GFP_KERNEL); > > Use 'inline' instead of '__inline__'26644:+static __inline__ void atomic_scrub(void *va, u32 size) Fixed missing \n. ... > A good start, thanks. The BUG_ON() thing might be unpopular, but I think it's > for the best. It should skip BUILD_BUG_ON though. BUILD_BUG_ON is now skipped (in my script, not sent to DaveJ yet). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists