linux-kernel - Re: [PATCH 28/36] Use menuconfig objects II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0704301641010.29151@yvahk01.tjqt.qr>
Date:	Mon, 30 Apr 2007 16:45:18 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Johannes Berg <johannes@...solutions.net>
cc:	Jaroslav Kysela <perex@...e.cz>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Liam Girdwood <liam.girdwood@...fsonmicro.com>
Subject: Re: [PATCH 28/36] Use menuconfig objects II - sound


On Apr 30 2007 16:19, Johannes Berg wrote:
>
>> --- linux-2.6.21-mm_20070428.orig/sound/aoa/Kconfig
>> +++ linux-2.6.21-mm_20070428/sound/aoa/Kconfig
>> @@ -1,9 +1,12 @@
>[...]
>
>For the aoa bits this ends up having two "Apple Onboard Audio driver"
>bits which is a bit confusing.

What, where? Oh damn.

> How about this instead? SND_AOA was
>pretty much a generic symbol to start with since it will cause snd-aoa
>to be compiled but is pretty much useless on it's own. This hence makes
>the core bits an invisible symbol.
>
>--- wireless-dev.orig/sound/aoa/Kconfig	2006-10-08 19:56:35.000000000 +0200
>+++ wireless-dev/sound/aoa/Kconfig	2007-04-30 16:18:12.935651366 +0200
>@@ -1,13 +1,15 @@
>+menuconfig SND_AOA
>+	bool "Apple Onboard Audio driver"
>+	depends on PPC_PMAC
> 	select SND_PCM
>-	---help---
>-	This option enables the new driver for the various
>-	Apple Onboard Audio components.
>+	help
>+	  This option enables the new driver for the various
>+	  Apple Onboard Audio components.
>+
>+if SND_AOA
>+
>+config SND_AOA_CORE
>+	tristate

Why the extra AOA_CORE? Are there some options that require only AOA
but not AOA_CORE?


Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/