linux-kernel - Re: [patch] pm: include EIO from errno-base.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704300751.07078.david-b@pacbell.net>
Date:	Mon, 30 Apr 2007 07:51:06 -0700
From:	David Brownell <david-b@...bell.net>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch] pm: include EIO from errno-base.h

On Monday 30 April 2007, David Rientjes wrote:
> call_platform_enable_wakeup() uses EIO, so it needs to be defined.
> 
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Signed-off-by: David Rientjes <rientjes@...gle.com>

Actually, in that PM-is-disabled case returning zero (success)
rather than -EIO would have been the backwards-compatible
approach ... the hook not being there shouldn't be an error.
And returning zero wouldn't require this #include either...

- Dave


> ---
>  include/linux/pm.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>  
>  #include <linux/list.h>
>  #include <asm/atomic.h>
> +#include <asm/errno.h>
>  
>  /*
>   * Power management requests... these are passed to pm_send_all() and friends.
> 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/