[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070430160508.25315f16@the-village.bc.nu>
Date: Mon, 30 Apr 2007 16:05:08 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Juergen Beisert <juergen127@...uzholzen.de>
Cc: linux-kernel@...r.kernel.org, Mikael Pettersson <mikpe@...uu.se>
Subject: Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work
as expected
On Mon, 30 Apr 2007 15:09:58 +0200
Juergen Beisert <juergen127@...uzholzen.de> wrote:
> From: Juergen Beisert <juergen.beisert@...henstephan.org>
>
> Replace NSC/Cyrix specific chipset access macros by inlined functions.
> With the macros a line like this fails (and does nothing):
> setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);
> With inlined functions this line will work as expected.
>
> Note about a side effect: Seems on Geode GX1 based systems the
> "suspend on halt power saving feature" was never enabled due to this
> wrong macro expansion. With inlined functions it will be enabled, but
> this will stop the TSC when the CPU runs into a HLT instruction.
> Kernel output something like this:
> Clocksource tsc unstable (delta = -472746897 ns)
> Tested on a Geode GX1 system.
>
> Signed-off-by: Juergen Beisert <juergen.beisert@...henstephan.org>
Acked-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists