linux-kernel - Re: [PATCH 06/12] i386: Minimum cpu detection cleanups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463615BA.4020703@zytor.com>
Date:	Mon, 30 Apr 2007 09:13:46 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Andi Kleen <ak@...e.de>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	linux-kernel@...r.kernel.org, Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [PATCH 06/12] i386: Minimum cpu detection cleanups.

Eric W. Biederman wrote:
> 
> diff --git a/arch/i386/kernel/verify_cpu.S b/arch/i386/kernel/verify_cpu.S
> index ba9e03e..e51a869 100644
> --- a/arch/i386/kernel/verify_cpu.S
> +++ b/arch/i386/kernel/verify_cpu.S
> @@ -4,10 +4,6 @@
>  #include <asm/cpufeature.h>
>  
>  verify_cpu:
> -#if REQUIRED_MASK1 == 0
> -	xorl %eax,%eax
> -	ret
> -#endif
>  	pushfl				# Save caller passed flags
>  	pushl	$0			# Kill any dangerous flags
>  	popfl
> @@ -21,7 +17,7 @@ verify_cpu:
>  	testl	$(1<<18),%eax
                 ^^^^^^^
>  	jz	bad

While you're in there can you change references to the flags to use the
<asm/cpuflags.h> constants?

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/