linux-kernel - Re: condingstyle, was Re: utrace comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Apr 2007 14:39:23 -0400
From:	Daniel Hazelton <dhazelton@...er.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Roland McGrath <roland@...hat.com>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: condingstyle, was Re: utrace comments

On Monday 30 April 2007 13:09:17 Andrew Morton wrote:
> On Mon, 30 Apr 2007 10:11:21 +0100 Christoph Hellwig <hch@...radead.org> 
wrote:
> > I've separated this out under a new subject because some style issues
> > that so far aren't documented explicitly are in doubt here, and Roland
> > wants and Answer from Andrew.
> >
> > We also should put clauses on this into CodingStyle.
> >
> > On Sun, Apr 29, 2007 at 09:02:13PM -0700, Roland McGrath wrote:
> > > > 	The coding style here is wrong.  The else should be on the line
> > > > 	of the closing brace.
> > >
> > > I can ordinarily ignore syntax, but this is an abomination in the sight
> > > of the Lord and always will be.  Fortunately, it's far from being 100%
> > > consistently used in the kernel already.  People are welcome to change
> > > the code after I submit it, but I just can't make myself write it that
> > > way, sorry.
>
> I'm a bit lost here.  Are we referring to
>
> 	if (expr) {
> 		...
> 	} else {
> 		...
> 	}
>
> versus
>
> 	if (expr) {
> 		...
> 	}
> 	else {
> 		...
> 	}
>
> ?

For some strange reason I have a feeling its the former. I remember that one 
of the "Rules of Style" that are pushed by a lot of people is to "Uncuddle 
the Else".

I prefer the '} else {'  style - for the same reason that I prefer the 
'float logf(float x) {' style for functions and similar (where it doesn't go 
beyond 80 columns) in my own code. The reason is that I like trying to keep 
the number of lines with no code on them minimal - helps me to look at the 
output of wc -l to find files where I might have been overly verbose with the 
code and/or comments.

DRH


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/