linux-kernel - Re: [PATCH] [30/30] x86_64: Add missing !X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 May 2007 06:26:23 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Andi Kleen <ak@...e.de>
CC:	ebiederm@...ssion.com, patches@...-64.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the
 2G/2G split.

Andi Kleen a écrit :
> From: ebiederm@...ssion.com
> 
> When in PAE mode we require that the user kernel divide to be
> on a 1G boundary.  The 2G/2G split does not have that property
> so require !X86_PAE
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> ---
>  arch/i386/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index 1a94a73..80003de 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -570,6 +570,7 @@ choice
>  		depends on !HIGHMEM
>  		bool "3G/1G user/kernel split (for full 1G low memory)"
>  	config VMSPLIT_2G
> +		depends on !X86_PAE
>  		bool "2G/2G user/kernel split"
>  	config VMSPLIT_1G
>  		bool "1G/3G user/kernel split"

Hum... We lose a usefull 2G/2G split. Should'nt we use a patch to change 
PAGE_OFFSET to 0x8000000 instead of 0x78000000 and keep 2G/2G split ?

Maybe the following patch is better ?

[PATCH] i386 : Adjust CONFIG_PAGE_OFFSET in case of 2G/2G split and X86_PAE

When in PAE mode we require that the user kernel divide to be
on a 1G boundary.  We must therefore make sure PAGE_OFFSET is correctlty 
defined in the 2G/2G split and PAE mode.

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

View attachment "i386_CONFIG_PAGE_OFFSET.patch" of type "text/plain" (415 bytes)