linux-kernel - [PATCH] 8250: Remove commented out irq cruft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Apr 2007 20:59:07 -0500
From:	"Josh Boyer" <jwboyer@...il.com>
To:	akpm@...ux-foundation.org
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: [PATCH] 8250: Remove commented out irq cruft

Remove some obviously old interrupt disable/enable code that has been
commented out.

Signed-off-by: Josh Boyer <jwboyer@...il.com>

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 90621c3..b37856a 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -913,7 +913,6 @@ static void autoconfig(struct uart_8250_port *up, unsigned i
         * be frobbing the chips IRQ enable register to see if it exists.
         */
        spin_lock_irqsave(&up->port.lock, flags);
-//     save_flags(flags); cli();

        up->capabilities = 0;
        up->bugs = 0;
@@ -1070,7 +1069,6 @@ static void autoconfig(struct uart_8250_port *up, unsigned

  out:
        spin_unlock_irqrestore(&up->port.lock, flags);
-//     restore_flags(flags);
        DEBUG_AUTOCONF("type=%s\n", uart_config[up->port.type].name);
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/