linux-kernel - Re: condingstyle, was Re: utrace comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9185.1178035627@redhat.com>
Date:	Tue, 01 May 2007 17:07:07 +0100
From:	David Howells <dhowells@...hat.com>
To:	"John Anthony Kazos Jr." <jakj@...-k-j.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Roland McGrath <roland@...hat.com>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: condingstyle, was Re: utrace comments 

John Anthony Kazos Jr. <jakj@...-k-j.com> wrote:

> 	if (veryverylengthycondition1
> 		&& smallcond2
> 		&& (conditionnumber3a
> 			|| condition3b)) {
> 		...
> 	}
> 
> Clear, crisp, and 80-wide. I also like how the logical operator on the 
> following line is indented slightly into the condition of the previous 
> line.

The brain works better when associated things are lined up, so:

	if (veryverylengthycondition1 &&
	    smallcond2 &&
	    (conditionnumber3a ||
	     condition3b)) {

is better as it gives a visual clue to association.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/