linux-kernel - Re: [PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178039010.6754.20.camel@localhost>
Date:	Tue, 01 May 2007 14:03:30 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, michael@...u.de,
	Hans Verkuil <hverkuil@...all.nl>,
	v4l-dvb maintainer list <v4l-dvb-maintainer@...uxtv.org>
Subject: Re: [PATCH] VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

Hi Robert,

Em Sáb, 2007-04-28 às 06:32 -0400, Robert P. J. Day escreveu:
> Replace the call to MINOR() with a call to the inline iminor()
> routine.
> 
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
> ---
> 
> that's the last of those changes, but it's not clear who the official
> maintainer is, so i took a chance and picked a likely looking victim
> out of the MAINTAINERS file.  apologies if i picked wrong.

You've picked it wrongly. The Maintainer for ivtv is Hans Verkuil.
However, for every stuff under drivers/media, you can reach the active
maintainers at v4l-dvb-maintainers list
(v4l-dvb-maintainer@...uxtv.org).

Hans,

If you are ok with this trivial change, please send me your acked-by or
SOB for me to commit and send to mainstream.
> 
> 
> diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
> index 1637097..8976487 100644
> --- a/drivers/media/video/ivtv/ivtv-fileops.c
> +++ b/drivers/media/video/ivtv/ivtv-fileops.c
> @@ -804,7 +804,7 @@ int ivtv_v4l2_open(struct inode *inode, struct file *filp)
>  	struct ivtv_open_id *item;
>  	struct ivtv *itv = NULL;
>  	struct ivtv_stream *s = NULL;
> -	int minor = MINOR(inode->i_rdev);
> +	int minor = iminor(inode);
> 
>  	/* Find which card this open was on */
>  	spin_lock(&ivtv_cards_lock);
-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/