linux-kernel - Re: [1/3] dynamically allocate IRQ stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070501170426.GA9376@osiris.ibm.com>
Date:	Tue, 1 May 2007 19:04:26 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Bill Irwin <bill.irwin@...cle.com>, linux-kernel@...r.kernel.org,
	bunk@...sta.de, akpm@...l.org, gcoady@...il.com, zlynx@....org,
	dgc@....com, alan@...rguk.ukuu.org.uk, andi@...stfloor.org,
	hch@...radead.org, jengelh@...ux01.gwdg.de, zwane@...radead.org,
	neilb@...e.de, jens.axboe@...cle.com, eric@...venscaling.com
Subject: Re: [1/3] dynamically allocate IRQ stacks

> +static void * __init __alloc_irqstack(int cpu)
> +{
> +	if (!cpu)
> +		return __alloc_bootmem(THREAD_SIZE, THREAD_SIZE,
> +						__pa(MAX_DMA_ADDRESS));
> +
> +	return (void *)__get_free_pages(GFP_KERNEL,
> +					ilog2(THREAD_SIZE/PAGE_SIZE));
> +}

I think you should test for slab_is_available() instead of checking
if the cpu number is 0.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/