linux-kernel - Re: [patch 29/33] SONIC interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070501211243.GA27018@infradead.org>
Date:	Tue, 1 May 2007 22:12:43 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Finn Thain <fthain@...egraphics.com.au>
Subject: Re: [patch 29/33] SONIC interrupt handling

On Tue, May 01, 2007 at 10:33:03PM +0200, Geert Uytterhoeven wrote:
> +static int jazzsonic_open(struct net_device* dev) {
> +	if (request_irq(dev->irq, &sonic_interrupt, IRQF_DISABLED, "sonic", dev)) {
> +		printk(KERN_ERR "\n%s: unable to get IRQ %d.\n", dev->name, dev->irq);
> +		return -EAGAIN;
> +	}
> +	return sonic_open(dev);
> +}

Opening brace for a function on a line of it's own please.

Also starting a printk with '\n' seems rather odd.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/