linux-kernel - Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070502001035.873880ba.pj@sgi.com>
Date:	Wed, 2 May 2007 00:10:35 -0700
From:	Paul Jackson <pj@....com>
To:	"Paul Menage" <menage@...gle.com>
Cc:	rientjes@...gle.com, torvalds@...ux-foundation.org,
	clameter@...ulhu.engr.sgi.com, linux-kernel@...r.kernel.org
Subject: Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for
 unpopulated cpuset

Paul M wrote:
> Otherwise the only way to reclaim
> the node for a different sibling is to delete the cpuset.

I couldn't make sense of that sentence.  Could you restate it?

> Yes, but that's arguably an artefact of the user using the wrong tool
> to update the cpu/node set. Doing "echo -n > /dev/cpuset/foobar/mems"
> has the expected effect.

While it is true that 'echo -n' works here, I think that this will
cause confusion and irritation to users.  We have gone out of our way
for years now to support newlines as optional trailing characters on
input to the various bitmask formats, and to provide the newline on
output, in order to provide a comfortable interface for use from shell
scripts and prompts.

I think it would be an annoying inconsistency to not do so here.

I'd vote for adding a couple of lines of code to handle this:

+	char *bp;

+	bp = buf;
+	while (isspace(*bp))
+		bp++;
+	if (!*bp) {
+		cpus_clear(trialcs.cpus_allowed);
+	} else {

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/