linux-kernel - Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070502012647.fbc0d502.pj@sgi.com>
Date:	Wed, 2 May 2007 01:26:47 -0700
From:	Paul Jackson <pj@....com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	torvalds@...ux-foundation.org, menage@...gle.com,
	clameter@...ulhu.engr.sgi.com, linux-kernel@...r.kernel.org
Subject: Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for
 unpopulated cpuset

Other than the detail of allowing a newline from doing:

	echo > cpus

to work, I'm ok with this patch.  It passes my cpuset_test,
and seems to allow unpopulating cpusets, as advertised.

Aha - as I was writing this, I noticed that the command:

  echo -n '' > cpus

does -not- work!  The echo command recognizes that as a write
of zero non-null bytes, and skips the write altogether.

We have to add the code to handle an input line consisting of
just a bare newline, to mean an empty mask.  Well, we don't
-have- to.  But writing a single nul byte in shell script will
challenge most shell script hackers.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/