linux-kernel - Re: do_tty_write() can block even with O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070502170250.09ae354c@the-village.bc.nu>
Date:	Wed, 2 May 2007 17:02:50 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dave Johnson <djohnson+linux-kernel@...starentnetworks.com>,
	akpm@...l.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: do_tty_write() can block even with O_NONBLOCK?

On Wed, 2 May 2007 11:17:00 -0400
Dave Johnson <djohnson+linux-kernel@...starentnetworks.com> wrote:

> 
> I have two processes with the same tty open, one opens blocking and
> one opens nonblocking.
> 
> If the blocking process blocks doing a write (due to flow control,
> just going to fast, etc...) the nonblocking process will also block
> when it writes until the blocking process unblocks.
> 
> This seems to occur because do_tty_write() isn't checking for
> O_NONBLOCK when taking the tty's write mutex.
> 
> 
> Signed-off-by: Dave Johnson <djohnson+linux-kernel@...starentnetworks.com>

Acked-by: Alan Cox <alan@...hat.com>

Looks fine to me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/