linux-kernel - Re: [PATCH 3/6] firewire: char device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4638B6F5.9070802@s5r6.in-berlin.de>
Date:	Wed, 02 May 2007 18:06:13 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	John Stoffel <john@...ffel.org>
CC:	Kristian H??gsberg <krh@...hat.com>, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3/6] firewire: char device interface

John Stoffel wrote:
>>>>>> "Stefan" == Stefan Richter <stefanr@...6.in-berlin.de> writes:
[...]

Hmm, I'm just spotting some artifacts after a recent file-renaming patch:

> Stefan> --- /dev/null
> Stefan> +++ linux_juju/include/linux/firewire-cdev.h
                                       ^^^^^^^^^^^^^^^
> Stefan> @@ -0,0 +1,268 @@
> Stefan> +/*						-*- c-basic-offset: 8 -*-
> Stefan> + *
> Stefan> + * fw-device-cdev.h -- Char device interface.
              ^^^^^^^^^^^^^^^^
[...]
> Stefan> +#ifndef __fw_cdev_h
> Stefan> +#define __fw_cdev_h
                   ^^^^^^^^^^^
[...]
> Stefan> +#define TCODE_WRITE_QUADLET_REQUEST	0
> Stefan> +#define TCODE_WRITE_BLOCK_REQUEST	1
[...]
> Stefan> +#define SCODE_100			0x0
> Stefan> +#define SCODE_200			0x1
> Stefan> +#define SCODE_400			0x2
> Stefan> +#define SCODE_800			0x3
> Stefan> +#define SCODE_1600			0x4
> Stefan> +#define SCODE_3200			0x5
> 
> These are also defined in fw-transaction.h, though that file doesn't
> have all the values.  Can these just be combined into a single
> fw-constants.h file instead?  
> 
> I honestly haven't checked all your defines....
[...]

Right, there are some overlaps...

Note, firewire-cdev.h declares a userspace ABI, while fw-transaction.h
declares an in-kernel API.  I'm not quite sure right now how it should
rather be organized.  Maybe rename fw-transaction.h's macros.  Only
fw-cdev.c (which implements the userspace ABI) includes both header files.

(PS: I'm not the author; only subsystem maintainer.)
-- 
Stefan Richter
-=====-=-=== -=-= ---=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/