linux-kernel - Re: [patch 01/10] compiler: define __attribute_unused_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705021014070.3033@chino.kir.corp.google.com>
Date:	Wed, 2 May 2007 10:16:15 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Adrian Bunk <bunk@...sta.de>
cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 01/10] compiler: define __attribute_unused__

On Wed, 2 May 2007, Adrian Bunk wrote:

> If we don't want any warnings with CONFIG_PCI=n, CONFIG_SYSFS=n or
> CONFIG_PROC_FS=n, we'd have to annotate _many_ functions.
> 
> If the lonterm goal is to compile the kernel with -Werror then we need 
> -Wno-unused-function, not annotating individual functions.
> 

That's only addressing part of the issue.  What about automatic or static 
external variables that are declared but may go unreferenced depending on 
preprocessor macros?  You need to annotate them with __attribute__ 
((unused)) to suppress compiler warnings.  Globally disabling such 
warnings would eventually cause unused code to go unnoticed.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/